diff: add grouped diff gutter actions#21
Conversation
hewigovens
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'group' column in the diff gutter, featuring a vertical stripe to visually represent contiguous change hunks. The implementation includes a new DiffGutterGrouping utility for range expansion, updates to DiffGutterTextView for handling interactions in the new gutter regions, and enhancements to DiffLayoutManager for stripe rendering. Additionally, gutter-related actions and types were refactored into dedicated files. Review feedback suggests avoiding hardcoded colors in the view logic to support better theming and optimizing the measurement of gutter line widths by using the attributed string's size directly.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a02493bc00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hewigovens
force-pushed
the
codex/diff-group-gutter
branch
8 times, most recently
from
03b406d to
07eb0a8
Compare
hewigovens
force-pushed
the
codex/diff-group-gutter
branch
from
07eb0a8 to
b9ade7f
Compare
1 participant
Summary
Validation
swift testinshell/mac/Packages/JayJayDiffUIjust build